[Kernel] Fix binary comparator to use the unsigned comparison #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkorukanti can you please review? |
vkorukanti
approved these changes
Aug 28, 2024
vkorukanti
changed the title
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Aug 30, 2024
…elta-io#3617) Fixed binary comparator. Previously, bytes were compared as signed, which was incorrect. Tests added to `DefaultExpressionEvaluatorSuite.scala`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Fixed binary comparator. Previously, bytes were compared as signed, which was incorrect.
How was this patch tested?
Tests added to
DefaultExpressionEvaluatorSuite.scalaDoes this PR introduce any user-facing changes?
No.