Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Spark] Add DeltaTable.addFeatureSupport API to PySpark #3786

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

xupefei
Copy link
Contributor

@xupefei xupefei commented Oct 21, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR introduces a DeltaTable.addFeatureSupport API which was missing in PySpark. This API is used to add support of a table feature to a given Delta table.

How was this patch tested?

A new test is added.

Does this PR introduce any user-facing changes?

Yes. See the above Description section.

@xupefei
Copy link
Contributor Author

xupefei commented Oct 21, 2024

Hey @longvu-db, it is you who found this API missing. Could you review this PR?

Copy link
Contributor

@longvu-db longvu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on ensuring API Parity @xupefei :)!

Btw, just in case you forget, could we add [Spark] to the title?

python/delta/tables.py Outdated Show resolved Hide resolved
python/delta/tables.py Outdated Show resolved Hide resolved
python/delta/tables.py Outdated Show resolved Hide resolved
python/delta/tables.py Outdated Show resolved Hide resolved
python/delta/tables.py Show resolved Hide resolved
python/delta/tests/test_deltatable.py Outdated Show resolved Hide resolved
@xupefei xupefei changed the title Add DeltaTable.addFeatureSupport API to PySpark [Spark] Add DeltaTable.addFeatureSupport API to PySpark Oct 22, 2024
python/delta/tables.py Outdated Show resolved Hide resolved
@xupefei xupefei requested a review from longvu-db November 7, 2024 12:21
Copy link
Contributor

@longvu-db longvu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scottsand-db scottsand-db merged commit 520c8e8 into delta-io:master Nov 7, 2024
16 of 19 checks passed
@xupefei xupefei deleted the api-addfeaturesupport branch November 7, 2024 16:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants