Adding PSP template and values #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm happy to accept this but my only reservation is that psp is dead. Should we bother? If we decide to proceed let's bump the version of the Chart so ci will properly create a new build for us. |
|
I would say Yes as we all know cluster upgrades can have a long tail and even tho PSP is going away in 1.25. It's going to be a while until that is common. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of democratic-csi/democratic-csi#188
In this PR I'm adding a PSP for the controller and nodes pods. (I used Longhorn's PSP and chart as a framework here.
Note: I'm leaving the default behavior the same with it being setting the values.yaml to
enablePSP: falseIE Helm will not create the PSP, role, and rolebindings unless a user enables it.