fix: Publishing dev server keeps running after exiting on Windows #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinslin
requested changes
Jan 3, 2022
|
looks like there's a compiler error |
|
Works now! |
|
The failing windows plugin tests work fine locally. |
kevinslin
approved these changes
Jan 7, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where on Windows, the next server would continue running even after the Dendron CLI is interrupted with Ctrl+C.
I believe this change will cause a terminal window to appear when using the publish dev plugin command, but I was unfortunately unable to test that. This is necessary because it appears that Windows otherwise doesn't let applications handle an interrupt, so node/execa can't stop the server when Dendron exits. See: nodejs/node#29837