Specify length in SCRAM deriveKeySignatures #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! We were playing with this library and tried to use it from the browser. SCRAM implementation didn't work for us and after some investigation, we found a bug in Deno (denoland/deno#16180) which was responsible for the issue.
The bug is that HMAC/SHA-256 object for
deriveKeyalso has an optionallengthfield, which is different in the browser and Deno. After explicitly specifyinglength: 256, SCRAM works well both in Deno and browser/cloudflare workers.