Skip to content

Commit

Permalink
feat: hide several --unstable-* flags (#25378)
Browse files Browse the repository at this point in the history
This commit hides following unstable flags:
- `--unstable-ffi` (the API is now stable)
- `--unstable-webgpu` (this API is now stable)
- `--unstable-fs` (no more unstable APIs)
- `--unstable-byonm` (BYONM is on by default)


The flags are still parseable, but they are not used. Concrete cleanup
will be done in a follow up PR.
  • Loading branch information
bartlomieju authored Sep 3, 2024
1 parent 90338ef commit b9b4b0d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
6 changes: 0 additions & 6 deletions cli/args/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3848,15 +3848,9 @@ impl Iterator for UnstableArgsIter {
} else if self.idx == 2 {
Arg::new("unstable-byonm")
.long("unstable-byonm")
.help("Enable unstable 'bring your own node_modules' feature")
.value_parser(FalseyValueParser::new())
.action(ArgAction::SetTrue)
.hide(true)
.long_help(match self.cfg {
UnstableArgsConfig::None => None,
UnstableArgsConfig::ResolutionOnly
| UnstableArgsConfig::ResolutionAndRuntime => Some("true"),
})
.help_heading(UNSTABLE_HEADING)
} else if self.idx == 3 {
Arg::new("unstable-sloppy-imports")
Expand Down
6 changes: 3 additions & 3 deletions runtime/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ pub static UNSTABLE_GRANULAR_FLAGS: &[UnstableGranularFlag] = &[
UnstableGranularFlag {
name: deno_ffi::UNSTABLE_FEATURE_NAME,
help_text: "Enable unstable FFI APIs",
show_in_help: true,
show_in_help: false,
id: 3,
},
UnstableGranularFlag {
name: deno_fs::UNSTABLE_FEATURE_NAME,
help_text: "Enable unstable file system APIs",
show_in_help: true,
show_in_help: false,
id: 4,
},
UnstableGranularFlag {
Expand Down Expand Up @@ -123,7 +123,7 @@ pub static UNSTABLE_GRANULAR_FLAGS: &[UnstableGranularFlag] = &[
UnstableGranularFlag {
name: deno_webgpu::UNSTABLE_FEATURE_NAME,
help_text: "Enable unstable `WebGPU` API",
show_in_help: true,
show_in_help: false,
id: 11,
},
UnstableGranularFlag {
Expand Down

0 comments on commit b9b4b0d

Please # to comment.