Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(compat): add support for node: prefixed built-ins #12337

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 5, 2021

Adds support for "node:" prefix for Node built-ins in "--compat" mode.

As per https://nodejs.org/api/esm.html#esm_node_imports

Towards #12295

@bartlomieju bartlomieju mentioned this pull request Oct 5, 2021
7 tasks
@bartlomieju bartlomieju requested a review from ry October 5, 2021 22:40
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 37a24c7 into denoland:main Oct 5, 2021
@bartlomieju bartlomieju deleted the compat_node_prefix branch October 5, 2021 23:25
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
Adds support for "node:" prefix for Node built-ins in "--compat" mode.

As per https://nodejs.org/api/esm.html#esm_node_imports
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants