fix(task): remove --no-config as task subcommand argument #14983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
Jun 27, 2022
cli/flags.rs
Outdated
Comment on lines
2097
to
2104
| Arg::new("config") | ||
| .short('c') | ||
| .long("config") | ||
| .value_name("FILE") | ||
| .help("Specify the configuration file") | ||
| .long_help(CONFIG_HELP.as_str()) | ||
| .takes_value(true) | ||
| .value_hint(ValueHint::FilePath) |
There was a problem hiding this comment.
Consider splitting config_args() into config_arg and no_config_arg and applying them to all relevant subcommands. I think this is better than duplicating arg definition
bartlomieju
reviewed
Jun 28, 2022
cli/args/flags.rs
Outdated
| @@ -2997,6 +3003,14 @@ fn config_args_parse(flags: &mut Flags, matches: &ArgMatches) { | |||
| }; | |||
| } | |||
|
|
|||
| fn task_args_parse(flags: &mut Flags, matches: &ArgMatches) { | |||
There was a problem hiding this comment.
Please inline contents of this function into task_parse, there's no need for a separate function.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14971.