fix(ext/crypto): add missing EcdhKeyDeriveParams type to algorithm parameters of SubtleCrypto.deriveKey #15005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
negrel
force-pushed
the
fix-subtle-crypto-deriveKey-types
branch
from
04653cd
to
9fb1afc
Compare
…rameter of SubtleCrypto.deriveKey
negrel
force-pushed
the
fix-subtle-crypto-deriveKey-types
branch
from
9fb1afc
to
e7d2f91
Compare
littledivy
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Thanks! @negrel Please sign the CLA so we can land this PR.
|
Done! 😀 |
littledivy
approved these changes
Jun 30, 2022
dsherret
pushed a commit
to dsherret/deno
that referenced
this pull request
Jun 30, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14936