Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf(ext/web): avoid reallocations in op_base64_atob #15018

Merged
merged 2 commits into from
Jun 30, 2022
Merged

perf(ext/web): avoid reallocations in op_base64_atob #15018

merged 2 commits into from
Jun 30, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jun 30, 2022 •
edited
Loading

Follow-up to #15008

op_base64_atob did SmallVec => Vec and vice-versa.
This commit makes it use SmallVec directly.

main -

b64Short:       n = 1000000,            dt = 0.225s,    freq = 4438775.950/s,   time = 225ns/op

this patch -

b64Short:       n = 1000000,            dt = 0.185s,    freq = 5404132.279/s,   time = 185ns/op

@littledivy littledivy merged commit 4e92f38 into denoland:main Jun 30, 2022
dsherret pushed a commit to dsherret/deno that referenced this pull request Jun 30, 2022
@littledivy @dsherret
perf(ext/web): avoid reallocations in op_base64_atob (denoland#15018)
2cfda9d
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju