refactor(ext/http): use String.prototype.trim() instead of regex #17722

piscisaureus · 2023-02-10T18:49:05Z

No description provided.

dsherret

LGTM

piscisaureus requested review from dsherret and bartlomieju February 10, 2023 18:49

piscisaureus force-pushed the fix-regex branch 2 times, most recently from 9bde76c to 83c2dd4 Compare February 10, 2023 18:58

refactor(ext/http): use String.prototype.trim instead of regex

f0b072c

piscisaureus force-pushed the fix-regex branch from 83c2dd4 to f0b072c Compare February 10, 2023 19:10

piscisaureus changed the title ~~fix(ext/http): remove inefficient regular expression~~ refactor(ext/http): use String.prototype.trim instead of regex Feb 10, 2023

piscisaureus changed the title ~~refactor(ext/http): use String.prototype.trim instead of regex~~ refactor(ext/http): use String.prototype.trim() instead of regex Feb 10, 2023

dsherret approved these changes Feb 10, 2023

View reviewed changes

piscisaureus enabled auto-merge (squash) February 10, 2023 19:27

piscisaureus merged commit cf06a7c into denoland:main Feb 10, 2023

piscisaureus deleted the fix-regex branch February 10, 2023 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(ext/http): use String.prototype.trim() instead of regex #17722

refactor(ext/http): use String.prototype.trim() instead of regex #17722

piscisaureus commented Feb 10, 2023

dsherret left a comment

refactor(ext/http): use String.prototype.trim() instead of regex #17722

refactor(ext/http): use String.prototype.trim() instead of regex #17722

Conversation

piscisaureus commented Feb 10, 2023

dsherret left a comment

Choose a reason for hiding this comment