Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf(ext/http): cache abort signal error #23548

Merged
merged 2 commits into from
Apr 25, 2024
Merged

perf(ext/http): cache abort signal error #23548

merged 2 commits into from
Apr 25, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Apr 25, 2024 •
edited
Loading

Fixes a perf regression introduced in eed2598 (flamegraph)

this patch:

Summary:
  Success rate: 100.00%
  Total:        10.0007 secs
  Slowest:      0.0145 secs
  Fastest:      0.0001 secs
  Average:      0.0006 secs
  Requests/sec: 80341.4816

  Total data:   9.19 MiB
  Size/request: 12
  Size/sec:     941.44 KiB

main:

Summary:
  Success rate: 100.00%
  Total:        10.0007 secs
  Slowest:      0.0068 secs
  Fastest:      0.0002 secs
  Average:      0.0009 secs
  Requests/sec: 56560.0551

  Total data:   6.47 MiB
  Size/request: 12
  Size/sec:     662.75 KiB

lucacasonato
lucacasonato reviewed Apr 25, 2024
View reviewed changes
@littledivy littledivy enabled auto-merge (squash) April 25, 2024 06:13
@littledivy littledivy merged commit e98862d into denoland:main Apr 25, 2024
17 checks passed
@littledivy littledivy deleted the abort_signal_error_perf branch April 25, 2024 07:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@littledivy @marvinhagemeister @lucacasonato