feat: async context #24402
Merged
feat: async context #24402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
commented
Jul 2, 2024
devsnek
force-pushed
the
async-context
branch
3 times, most recently
from
66783c5 to
5889a93
Compare
bartlomieju
reviewed
Jul 3, 2024
devsnek
force-pushed
the
async-context
branch
4 times, most recently
from
67d1585 to
8ba06ce
Compare
devsnek
added
node compat
node API
marvinhagemeister
approved these changes
Aug 1, 2024
bartlomieju
reviewed
Aug 2, 2024
Comment on lines
+91
to
+101
| const unboundCallback = callback; | ||
| const asyncContext = getAsyncContext(); | ||
| callback = () => { | ||
| const oldContext = getAsyncContext(asyncContext); | ||
| try { | ||
| setAsyncContext(asyncContext); | ||
| ReflectApply(unboundCallback, globalThis, args); | ||
| } finally { | ||
| setAsyncContext(oldContext); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Great that it will now work with timers!
devsnek
added a commit
that referenced
this pull request
Aug 2, 2024
Reverts #24402 deno_web can't depend on code in runtime
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are switching to ContinuationPreservedEmbedderData. This allows adding async context tracking to the various async operations that deno provides.
Fixes: #7010
Fixes: #22886
Fixes: #24368