Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ext/console): Error Cause Not Inspect-Formatted when printed #24526

Merged
merged 11 commits into from
Jul 22, 2024
Merged

fix(ext/console): Error Cause Not Inspect-Formatted when printed #24526

Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
da798b7
fix(ext/console): Ensure Error.cause is properly formatted when using…
MujahedSafaa Jul 11, 2024
5d12a8b
Use the equivalent for "JSON.stringify" from the `primordials` object
MujahedSafaa Jul 11, 2024
7577bd8
Merge branch 'denoland:main' into fix-error_cause-is-not-inspect-form…
MujahedSafaa Jul 14, 2024
9e728dc
Fix failed test inspectErrorCircular
MujahedSafaa Jul 15, 2024
41d9b4d
Update 01_console.js
MujahedSafaa Jul 15, 2024
30234d9
format code based on lint rules
MujahedSafaa Jul 15, 2024
901810f
Enhance code readability
MujahedSafaa Jul 15, 2024
5e91199
Add test use case
MujahedSafaa Jul 16, 2024
8817772
Change from stringify to inspect to handle all types of data
MujahedSafaa Jul 17, 2024
9f3a251
Merge branch 'main' into fix-error_cause-is-not-inspect-formatted
bartlomieju Jul 18, 2024
7b6b1db
Merge branch 'main' into fix-error_cause-is-not-inspect-formatted
bartlomieju Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ext/console/01_console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ const {
FunctionPrototypeBind,
FunctionPrototypeCall,
FunctionPrototypeToString,
JSONStringify,
MapPrototypeDelete,
MapPrototypeEntries,
MapPrototypeForEach,
Expand Down Expand Up @@ -1484,12 +1485,18 @@ function inspectError(value, ctx) {
finalMessage += `[${stack || ErrorPrototypeToString(value)}]`;
}
}
const doubleQuoteRegExp = new SafeRegExp('"', "g");
finalMessage += ArrayPrototypeJoin(
ArrayPrototypeMap(
causes,
(cause) =>
"\nCaused by " + (MapPrototypeGet(refMap, cause) ?? "") +
(cause?.stack ?? cause),
(cause?.stack ??
StringPrototypeReplace(
JSONStringify(cause, null, 2),
doubleQuoteRegExp,
"",
)),
),
"",
);
Expand Down