fix(node): revert invalid package target change #24539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jul 11, 2024
bartlomieju
pushed a commit
that referenced
this pull request
Jul 11, 2024
Reason is that `e` may contain an invalid package target nested deeply in the returned errors. We should probably add a `.code()` to all errors to make matching easier or make the errors flatter.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts this change (I'm not sure it causes a bug, but I thought about this in the morning):
https://github.com/denoland/deno/pull/24470/files/18cd4ff3ff5050e18647c781011a2bc3099cab5c..ac3e42eaaecc6cf89300b39c270029da3ecc1e63?diff=split&w=0
Reason is that
emay contain an invalid package target nested deeply in the returned errors. We should probably add a.code()to all errors to make matching easier or make the errors flatter.