Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(cron): improve error message for invalid cron names #24644

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Jul 18, 2024

When a cron name is invalid, it wasn't necessarily clear why. This change-set improves the error message to inform the user of the valid characters in a cron name.

@irbull irbull changed the title cron: improve error message for invalid cron names fix(cron): improve error message for invalid cron names Jul 18, 2024
When a cron name is invalid, it wasn't necessarily clear why. This
change-set improves the error message to inform the user of the valid
characters in a cron name.
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju merged commit 1722e0a into denoland:main Jul 18, 2024
17 checks passed
@irbull irbull deleted the cron-name branch July 18, 2024 21:04
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
When a cron name is invalid, it wasn't necessarily clear why. This
change-set improves the error message to inform the user of the valid
characters in a cron name.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants