Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(ext/node): read correct CPU usage stats on Linux #24732

Merged
merged 5 commits into from
Jul 26, 2024
Merged

fix(ext/node): read correct CPU usage stats on Linux #24732

merged 5 commits into from
Jul 26, 2024

Conversation

MrEconomical
Copy link
Contributor

@MrEconomical MrEconomical commented Jul 25, 2024 •
edited
Loading

Fixes issue #24731.

deno_fixed

The total CPU usage row is ignored and info from cpu0 and cpu1 is correctly read.

@MrEconomical
Skip total cpu row when reading from /proc/stat
4556112 
Signed-off-by: MrEconomical <47700125+MrEconomical@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MrEconomical MrEconomical mentioned this pull request Jul 25, 2024
Closed
@MrEconomical
Merge branch 'main' into main
152247c
@MrEconomical
Skip first line of lines iterator
e62a187 
Signed-off-by: MrEconomical <47700125+MrEconomical@users.noreply.github.com>
@dsherret dsherret requested a review from littledivy July 26, 2024 01:21
@MrEconomical
Add explanation comment
a51320a 
Signed-off-by: MrEconomical <47700125+MrEconomical@users.noreply.github.com>
@MrEconomical
Merge branch 'main' into main
6aa4a3b
littledivy
littledivy approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit f4952f7 into denoland:main Jul 26, 2024
17 checks passed
dsherret pushed a commit that referenced this pull request Jul 26, 2024
@MrEconomical @dsherret
fix(ext/node): read correct CPU usage stats on Linux (#24732)
3ba50bf 
Fixes #24731

<img width="554" alt="deno_fixed"
src="https://github.com/user-attachments/assets/691f2f89-d979-4ca5-be9a-cf51446cd9b2">

The total CPU usage row is ignored and info from `cpu0` and `cpu1` is
correctly read.

---------

Signed-off-by: MrEconomical <47700125+MrEconomical@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dsherret dsherret dsherret left review comments

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrEconomical @CLAassistant @dsherret @littledivy