Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(compile/windows): handle cjs re-export of relative path with parent component #24795

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(compile/windows): handle cjs re-export of relative path with parent component #24795

merged 1 commit into from
Jul 30, 2024

Conversation

dsherret
Copy link
Member

Closes #24785

bartlomieju
bartlomieju approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit fe884c5 into denoland:main Jul 30, 2024
17 checks passed
@dsherret dsherret deleted the fix_compile_windows_npm_relative_path branch July 30, 2024 20:46
crowlKats pushed a commit that referenced this pull request Jul 31, 2024
@dsherret @crowlKats
fix(compile/windows): handle cjs re-export of relative path with pare…
14d18d9 
…nt component (#24795)

Closes #24785

(cherry picked from commit fe884c5)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno compile - module not found on Windows in cjs pkg re-exporting relative path with parent component
2 participants
@dsherret @bartlomieju