Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(test): rename --allow-none to --permit-no-files #24809

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

lucacasonato
Copy link
Member

Fixes #24752

@lucacasonato lucacasonato requested a review from dsherret July 31, 2024 13:03
@bartlomieju bartlomieju added this to the 1.46 milestone Jul 31, 2024
@lucacasonato lucacasonato changed the title feat(test): rename --allow-none to --proceed-when-no-files feat(test): rename --allow-none to --permit-no-files Aug 1, 2024
@lucacasonato lucacasonato requested a review from dsherret August 2, 2024 12:43
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato enabled auto-merge (squash) August 2, 2024 13:12
@lucacasonato lucacasonato merged commit 84ff418 into main Aug 2, 2024
17 checks passed
@lucacasonato lucacasonato deleted the rename_allow_none_flag branch August 2, 2024 13:19
scarf005 added a commit to scarf005/blog that referenced this pull request Sep 4, 2024
scarf005 added a commit to scarf005/blog that referenced this pull request Sep 12, 2024
* fix: broken link

* chore: lint

* feat: update license date

* ci: use renamed flag

see: denoland/deno#24809

* fix: date
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename confusing --allow-none flag in deno test
3 participants