fix(compile): support workspace members importing other members #24909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Aug 6, 2024
| "value": format!( | ||
| "**Resolved Dependency**\n\n**Code**: file​://{}\n", | ||
| temp_dir.uri().join("project1/mod.ts").unwrap().path(), | ||
| ), |
There was a problem hiding this comment.
This seems worse, but also not a big deal? 🤷
dsherret
commented
Aug 6, 2024
| "asdfasdfasdf/": "jsr:/asdfasdfasdf@^0.0.0/", | ||
| "qwerqwer": "jsr:qwerqwer@^0.0.0", | ||
| "qwerqwer/": "jsr:/qwerqwer@^0.0.0/" | ||
| "chalk/": "npm:/chalk/" |
There was a problem hiding this comment.
This is no longer in the synthetic import map.
bartlomieju
approved these changes
Aug 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace resolution between members was broken because this resolution occured on load in deno graph. I moved it to deno_config (to be renamed deno_workspace) in order to just do it in the
WorkspaceResolver. I think this makes sense, but I'm not entirely sure. Regardless, it fixes the deno compile bug.Closes #24901