Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Don't shell out to unzip in deno upgrade/compile #24926

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

nathanwhit
Copy link
Member

Use the zip crate instead

Fixes #23988.

@bartlomieju bartlomieju added this to the 1.46 milestone Aug 7, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit merged commit 507e5b7 into denoland:main Aug 8, 2024
17 checks passed
@nathanwhit nathanwhit deleted the unzip branch August 8, 2024 07:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
4 participants