Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(permissions): link to docs in permission prompt #24948

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 8, 2024

This commit updates permission prompt to add a link
to the documentation for particular flag.

Additionally the box drawings around the prompt have been slightly
altered for better visibility.

Screenshot 2024-08-08 at 12 42 32

@bartlomieju bartlomieju requested review from ry and thisisjofrank August 8, 2024 10:42
@bartlomieju
Copy link
Member Author

bartlomieju commented Aug 8, 2024

Waiting on docs.deno.com update to provide redirects denoland/docs#691

@bartlomieju bartlomieju added this to the 1.46 milestone Aug 8, 2024
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit ab8802f into denoland:main Aug 8, 2024
17 checks passed
@bartlomieju bartlomieju deleted the update_permission_prmpt branch August 8, 2024 13:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants