feat: deno remove #24952
Merged
feat: deno remove #24952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
I just tried it. Works great with both deno.json and package.json.
One thing I noticed: if I add with deno add npm:chalk, I can't remove with deno rm npm:chalk; I have to use deno rm chalk. Not a big deal, but I think we could improve it further in the future.
LGTM!
marvinhagemeister
approved these changes
Aug 9, 2024
Signed-off-by: Satya Rohith <me@satyarohith.com>
|
@satyarohith I want to take another look at this on Monday. I'll merge it then. |
dsherret
commented
Aug 12, 2024
| if cli_factory.cli_options()?.enable_future_features() { | ||
| crate::module_loader::load_top_level_deps(&cli_factory).await?; | ||
| } | ||
| crate::module_loader::load_top_level_deps(&cli_factory).await?; |
There was a problem hiding this comment.
@bartlomieju do you know why we feature gated this? I feel like we should be running this even without DENO_FUTURE?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.