-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: glob and directory support for deno check
and deno cache
cli arg paths
#25001
feat: glob and directory support for deno check
and deno cache
cli arg paths
#25001
Conversation
@marvinhagemeister please review this PR? |
cli/graph_container.rs
Outdated
let mut resolved_files = Vec::new(); | ||
|
||
for pattern in patterns { | ||
let expanded = glob::glob(pattern).expect("Failed to read glob pattern"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this code should do something similar to what lint and fmt does (so not using glob directly and instead use PathOrPatternSet
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done; please review it again.
@dsherret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is solved?
I used the FileCollector with the same lint and fmt, but it did not support the requirement
it should type check all files that match the glob pattern but in lint and format it didn't do that I think the previous method is better than using FileCollector with the same as format and lint. |
@yazan-abdalrahman Could it be because the pattern is different in the screenshots? It's missing a - deno check ".\src\*\*.ts"
+ deno check ".\src\**\*.ts" |
@marvinhagemeister |
deno check
and deno cache
cli arg paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #24668
Closes #20813