Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(fmt): support HTML, Svelte, Vue, Astro and Angular #25019

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Aug 13, 2024

Initially this is a draft PR because there're pending optimizations from markup_fmt. Once I publish a new version of markup_fmt, I will update PR status. While in draft, this PR still can be reviewed.

Close #25015

@g-plane g-plane marked this pull request as ready for review August 14, 2024 02:12
@g-plane
Copy link
Contributor Author

g-plane commented Aug 14, 2024

Note: I've also upgraded Malva to enable formatting style attribute in HTML.

@bartlomieju
Copy link
Member

@g-plane we discussed this more internally and we'd like to have 2 unstable flags/configs for this PR: --unstable-html for HTML files and --unstable-markup for all the "framework formats". Could you please apply this change? I think we'll be good to merge this PR after that, unless we're still waiting for more crates updates?

@bartlomieju bartlomieju added this to the 1.46 milestone Aug 14, 2024
@g-plane
Copy link
Contributor Author

g-plane commented Aug 14, 2024

I'm fine with that, but can we call it --unstable-fmt-component instead of --unstable-fmt-markup?

@bartlomieju
Copy link
Member

I'm fine with that, but can we call it --unstable-fmt-component instead of --unstable-fmt-markup?

Sure!

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thank you @g-plane!

@bartlomieju bartlomieju merged commit 3a3315c into denoland:main Aug 14, 2024
17 checks passed
@g-plane g-plane deleted the fmt-html branch August 15, 2024 01:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants