Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(runtime/web_worker): populate SnapshotOptions for WebWorker when instantiated without snapshot #25280

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix(runtime/web_worker): populate SnapshotOptions for WebWorker when instantiated without snapshot #25280

merged 2 commits into from
Aug 29, 2024

Conversation

yuhr
Copy link
Contributor

@yuhr yuhr commented Aug 28, 2024

Fixes #25277

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yuhr
Copy link
Contributor Author

yuhr commented Aug 28, 2024

ci / test debug linux-aarch64 failed with a temporary error:

Error: Error: Request timeout: /repos/protocolbuffers/protobuf/releases?page=1

Could someone rerun this?

@bartlomieju bartlomieju requested a review from littledivy August 29, 2024 01:28
@littledivy littledivy merged commit 4f97261 into denoland:main Aug 29, 2024
17 checks passed
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
@yuhr @lucacasonato
fix(runtime/web_worker): populate SnapshotOptions for WebWorker w…
23383e5 
…hen instantiated without snapshot (#25280)

Fixes #25277
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why does WebWorker::from_options instantiate JsRuntime with no SnapshotOptions
4 participants
@yuhr @CLAassistant @littledivy @bartlomieju