Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(lsp): update diagnostics on npm install #25352

Merged
merged 4 commits into from
Sep 4, 2024
Merged

fix(lsp): update diagnostics on npm install #25352

merged 4 commits into from
Sep 4, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #21042.

marvinhagemeister
marvinhagemeister reviewed Sep 2, 2024
View reviewed changes
lucacasonato
lucacasonato approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dsherret
dsherret approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 84dc375 into denoland:main Sep 4, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-watch-for-npm-install branch September 4, 2024 12:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@dsherret dsherret dsherret approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BYONM requires restart of lsp after running npm install
4 participants
@nayeemrmn @marvinhagemeister @dsherret @lucacasonato