Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(inspector): Fix panic when re-entering runtime ops #25537

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(inspector): Fix panic when re-entering runtime ops #25537

merged 2 commits into from
Sep 10, 2024

Conversation

littledivy
Copy link
Member

Mark op_require_break_on_next_statement as reentrant and properly release borrow on the OpState. This fixes BorrowMut assertions when running with inspector + op metrics.

Fixes #25515

bartlomieju
bartlomieju approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@littledivy littledivy merged commit c4d0888 into denoland:main Sep 10, 2024
17 checks passed
@littledivy littledivy deleted the fix_inspector_reentrant branch September 10, 2024 02:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when attatching debugger
2 participants
@littledivy @bartlomieju