Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ext/node): use primordials in ext/node/polyfills/console.ts #25572

Merged

Conversation

jake-abed
Copy link
Contributor

Contributing toward #24236

  • Swapped Object.assign for ObjectAssign primordial.
  • Removed referencing TODO comment.

Please disregard if no longer desired.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@iuioiua iuioiua changed the title fix(ext/node): use primordials in in ext/node/polyfills/console.ts fix(ext/node): use primordials in ext/node/polyfills/console.ts Sep 11, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit 87bc47b into denoland:main Sep 11, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants