Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(serve): Support second parameter in deno serve #25606

Merged
merged 3 commits into from
Sep 12, 2024
Merged

feat(serve): Support second parameter in deno serve #25606

merged 3 commits into from
Sep 12, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Sep 12, 2024 •
edited
Loading

Closes #24099

bartlomieju
bartlomieju approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sweet :)

@nathanwhit nathanwhit enabled auto-merge (squash) September 12, 2024 21:51
@nathanwhit nathanwhit merged commit 7477c2d into denoland:main Sep 12, 2024
17 checks passed
@davidmytton davidmytton mentioned this pull request Sep 13, 2024
Closed
@frou
Copy link

frou commented Jan 22, 2025

Should this second parameter of the serve object's fetch(...) method, info: ServeHandlerInfo<Addr>, also exist on Deno Deploy? It seems to be undefined there.

@bartlomieju
Copy link
Member

Deno Deploy is not on Deno v2 yet

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno serve doesn't support the second connInfo parameter
3 participants
@nathanwhit @frou @bartlomieju