Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(fs): undeprecate Deno.FsWatcher.prototype.return() #25623

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 13, 2024

The opposite of #25445

@iuioiua iuioiua requested a review from kt3k September 13, 2024 23:15
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 51d926a into denoland:main Sep 16, 2024
17 checks passed
@iuioiua iuioiua deleted the undeprecate-fswatcher-return branch September 16, 2024 21:57
@dsherret
Copy link
Member

For the future, these kind of PRs probably shouldn't be a chore, but rather a revert so that it shows up in the auto-generated release notes and we can easily see to remove the other commit from the log.

@dsherret
Copy link
Member

@iuioiua oh wait, sorry I didn't realize the other PR was closed and not merged. That said, we probably should have included it in the auto-generated release notes by not using chore, but not a big deal.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants