fix(doc): surface graph errors as warnings #25888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Sep 26, 2024
| pub struct GraphValidOptions { | ||
| pub check_js: bool, | ||
| pub kind: GraphKind, | ||
| pub is_vendoring: bool, |
There was a problem hiding this comment.
No need for this anymore.
| /// Whether to exit the process for lockfile errors. | ||
| /// Otherwise, surfaces lockfile errors as errors. | ||
| pub exit_lockfile_errors: bool, | ||
| pub exit_integrity_errors: bool, |
There was a problem hiding this comment.
Renamed to make it clear that this isn't just for lockfile integrity errors anymore.
| @@ -127,8 +129,18 @@ pub async fn doc( | |||
| .create_graph(GraphKind::TypesOnly, module_specifiers.clone()) | |||
| .await?; | |||
|
|
|||
| if maybe_lockfile.is_some() { | |||
There was a problem hiding this comment.
Should not be conditional on the lockfile because this is overall integrity errors.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph errors were being silently ignored.