Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: don't warn on ignored signals on windows #26332

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Oct 16, 2024

Closes #26183.

The warnings are super noisy and not actionable for the user

@dsherret dsherret changed the title chore: don't warn on ignored signals on windows fix: don't warn on ignored signals on windows Oct 17, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit merged commit 167f674 into main Oct 17, 2024
17 checks passed
@nathanwhit nathanwhit deleted the windows-silence-signal-warning branch October 17, 2024 02:58
bartlomieju pushed a commit that referenced this pull request Oct 17, 2024
Closes #26183.

The warnings are super noisy and not actionable for the user
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs that ignore signals are noisy on Windows
2 participants