Clean up output from Batch files on Windows #4764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch is a funny language, and it has some weird quirks. One of these quirks is that it will output each line it executes before executing the line, UNLESS the line is pefixed with an "@" symbol.
Deno does not use an @ symbol in the generated .cmd files when installing scripts, resulting in this:
For the following generated file:
Simply adding an @ so the file appears like so:
Results in the following output when executing an installed deno program:
I think this matches other platforms better, and matches closer to the way native executables execute on Windows as well.
I hope you'll consider merging this!