Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up output from Batch files on Windows #4764

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

trgwii
Copy link
Contributor

@trgwii trgwii commented Apr 15, 2020

Batch is a funny language, and it has some weird quirks. One of these quirks is that it will output each line it executes before executing the line, UNLESS the line is pefixed with an "@" symbol.

Deno does not use an @ symbol in the generated .cmd files when installing scripts, resulting in this:
image

For the following generated file:

% generated by deno install %
deno.exe "run" "file:///C:/Users/Thomas/Documents/cowsay/cowsay.ts" %*

Simply adding an @ so the file appears like so:

% generated by deno install %
@deno.exe "run" "file:///C:/Users/Thomas/Documents/cowsay/cowsay.ts" %*

Results in the following output when executing an installed deno program:

image

I think this matches other platforms better, and matches closer to the way native executables execute on Windows as well.

I hope you'll consider merging this!

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the explanation!

@ry ry merged commit 42c421f into denoland:master Apr 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants