feat: Allow resolving "ext:" modules from "ext:" or "node:" modules #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Dec 6, 2023
| if specifier.starts_with("ext:") | ||
| && !referrer.starts_with("ext:") | ||
| && !referrer.starts_with("node:") | ||
| && referrer != "." |
There was a problem hiding this comment.
Referrer is "." when we are resolving top level specifier - in such case the specifier needs to be already resolved. It's a bit of code smell, but that code hasn't been touched in a couple years.
mmastrac
reviewed
Dec 6, 2023
| @@ -541,11 +569,14 @@ impl ModuleMap { | |||
| referrer: &str, | |||
| import_assertions: HashMap<String, String>, | |||
| ) -> Option<v8::Local<'s, v8::Module>> { | |||
There was a problem hiding this comment.
Follow-up for the future. Not for this PR, but it would be nice if this function was more rust-y and returned Result<Module, Error> and we had an extra small shim function that would throw the error and return None.
mmastrac
approved these changes
Dec 6, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new "ModuleMap::resolve" function was added that is now used in
favor of directly calling "loader.resolve". This method performs additional
checks that prohibit resolution of "ext:" modules from modules that are not
"ext:" or "node:" modules.
This will allow us to sunset "RuntimeOptions::preserve_snapshotted_modules"
and will greatly help with #263 and denoland/deno#21422.
A bit different approach than suggested in the issue, but closes #363.