fix(fast_check): improve overload handling in dts transform #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 29, 2024
There was a problem hiding this comment.
This is an integration test for swc-project/swc#9342
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Jul 31, 2024
Some perf gains in swc (I measured formatting and it was slightly faster). Includes: * denoland/deno_graph#508 * denoland/eszip#193
4 tasks
kdy1
pushed a commit
to swc-project/swc
that referenced
this pull request
Nov 6, 2024
In https://github.com/denoland/deno_graph/commits/main/src/fast_check/transform_dts.rs: From denoland/deno_graph@7f38d56 to denoland/deno_graph@258186c PR list: - [x] ~denoland/deno_graph#508. I don't port this pr because swc doesn't resolve `public_ranges`. However, I refer to https://github.com/oxc-project/oxc/blob/fac5042afafc6e1acd6953150f3857d086ba945d/crates/oxc_isolated_declarations/src/lib.rs#L421C24-L421C33 to fix the bugs. - [x] denoland/deno_graph#521 - [x] denoland/deno_graph#522 - [x] denoland/deno_graph#540 I will port the tests if I have spare time.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.