Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: cache bust jsr meta file when version not found for dynamic branches #511

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 7, 2024

@dsherret dsherret changed the title fix: cache bust jsr meta file when not in cache for dynamic branches fix: cache bust jsr meta file when version not found for dynamic branches Aug 7, 2024
@dsherret dsherret marked this pull request as ready for review August 7, 2024 12:08
@dsherret dsherret requested a review from bartlomieju August 7, 2024 12:08
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +3335 to +3336
// don't bother pre-allocating because adding to this should be rare
let mut restarted_pkgs = HashSet::new();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preallocate? 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I added the comment lol

@dsherret dsherret merged commit 1c3ad88 into denoland:main Aug 7, 2024
16 checks passed
@dsherret dsherret deleted the fix_cache_bust_jsr_meta_file_dynamic_imports branch August 7, 2024 12:21
dsherret added a commit to denoland/deno that referenced this pull request Aug 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants