Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: provide referrer when requesting jsx config #565

Merged
merged 3 commits into from
Jan 21, 2025
Merged

feat: provide referrer when requesting jsx config #565

merged 3 commits into from
Jan 21, 2025

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn mentioned this pull request Jan 20, 2025
Closed
@dsherret
Copy link
Member

#564 will fix the failing ecosystem test.

dsherret
dsherret approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder about adding a test here, but it's probably ok. We can probably just test in the CLI.

@nayeemrmn nayeemrmn merged commit 9d26d04 into denoland:main Jan 21, 2025
16 checks passed
@nayeemrmn nayeemrmn deleted the jsx-config-resolver-referrer branch January 21, 2025 04:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeemrmn @dsherret