Skip to content

Commit

Permalink
note bug behaviors
Browse files Browse the repository at this point in the history
  • Loading branch information
kt3k committed Feb 10, 2025
1 parent fb67093 commit 2f6fec2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 2 additions & 3 deletions semver/greater_than_range_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ Deno.test("greaterThanRange() handles equals operator", () => {
assertEquals(greaterThanRange(version, range), false);
});

// BUG `!=` operator type does not exist in semver and should be removed.
// TODO remove this test once `!=` operator is removed.
Deno.test("greaterThanRange() handles not equals operator", () => {
const version = {
major: 1,
Expand All @@ -199,12 +197,13 @@ Deno.test("greaterThanRange() handles not equals operator", () => {
build: [],
};
const range = [[{
operator: "!=" as unknown as Operator,
operator: "!=" as const,
major: 1,
minor: 0,
patch: 0,
prerelease: [],
build: [],
}]];
// FIXME(kt3k): This demonstrates a bug. This should be false
assertEquals(greaterThanRange(version, range), true);
});
3 changes: 2 additions & 1 deletion semver/less_than_range_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,13 @@ Deno.test("lessThanRange() handles not equals operator", () => {
build: [],
};
const range = [[{
operator: "!=" as unknown as Operator,
operator: "!=" as const,
major: 1,
minor: 0,
patch: 0,
prerelease: [],
build: [],
}]];
// FIXME(kt3k): This demonstrates a bug. This should be false
assertEquals(lessThanRange(version, range), true);
});

0 comments on commit 2f6fec2

Please # to comment.