fix minor NaN value bug

denoland · Feb 11, 2025 · 6ed9efb · 6ed9efb
1 parent ab02c95
commit 6ed9efb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/semver/parse_range.ts b/semver/parse_range.ts
@@ -253,7 +253,7 @@ function handleLessThanOperator(groups: RangeRegExpGroups): Comparator[] {
   if (majorIsWildcard) return [{ operator: "<", major: 0, minor: 0, patch: 0 }];
   if (minorIsWildcard) {
     if (patchIsWildcard) return [{ operator: "<", major, minor: 0, patch: 0 }];
-    return [{ operator: "<", major, minor, patch: 0 }];
+    return [{ operator: "<", major, minor: 0, patch: 0 }];
   }
   if (patchIsWildcard) return [{ operator: "<", major, minor, patch: 0 }];
   const prerelease = parsePrerelease(groups.prerelease ?? "");
@@ -316,7 +316,7 @@ function handleGreaterOrEqualOperator(groups: RangeRegExpGroups): Comparator[] {
   if (majorIsWildcard) return [ALL];
   if (minorIsWildcard) {
     if (patchIsWildcard) return [{ operator: ">=", major, minor: 0, patch: 0 }];
-    return [{ operator: ">=", major, minor, patch: 0 }];
+    return [{ operator: ">=", major, minor: 0, patch: 0 }];
   }
   if (patchIsWildcard) return [{ operator: ">=", major, minor, patch: 0 }];
   const prerelease = parsePrerelease(groups.prerelease ?? "");

diff --git a/semver/parse_range_test.ts b/semver/parse_range_test.ts
@@ -672,13 +672,13 @@ Deno.test("parseRange() handles wildcards", () => {
     [{ operator: "<", major: 1, minor: 0, patch: 0 }],
   ]);
   assertEquals(parseRange("<1.*.0"), [
-    [{ operator: "<", major: 1, minor: NaN, patch: 0 }],
+    [{ operator: "<", major: 1, minor: 0, patch: 0 }],
   ]);
   assertEquals(parseRange("<1.*.*"), [
     [{ operator: "<", major: 1, minor: 0, patch: 0 }],
   ]);
   assertEquals(parseRange(">=1.*.0"), [
-    [{ operator: ">=", major: 1, minor: NaN, patch: 0 }],
+    [{ operator: ">=", major: 1, minor: 0, patch: 0 }],
   ]);
   assertEquals(parseRange(">=1.*.*"), [
     [{ operator: ">=", major: 1, minor: 0, patch: 0 }],