feat(node/http): upgrade event #2157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally the `ArgParsingOptions` interface has been renamed to `ParseOptions`. This aligns with the precedent from TS's lib files where function option bags are named after the function that they are an options bag for (eg `Performance#mark` + `PerformanceMarkOptions`).
This commit improves the bytes module. The changes: - indexOf, lastIndexOf, and includes have been renamed to indexOfNeedle, lastIndexOfNeedle, and includesNeedle. This is done to differentiate them from the similarly called Uint8Array prototype methods. - JS doc comments have been re-written to be more extensive, and clearer. More examples have been added to them.
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
# Conflicts: # .github/workflows/ci.yml # .github/workflows/version_bump.yml # Releases.md # _tools/release/01_bump_version.ts # _tools/release/02_create_pr.ts # testing/README.md # testing/_test_utils.ts # testing/mock.ts # testing/mock_examples/internals_injection.ts # testing/mock_examples/internals_injection_test.ts # testing/mock_examples/parameter_injection.ts # testing/mock_examples/parameter_injection_test.ts # testing/mock_examples/random.ts # testing/mock_examples/random_test.ts # testing/mock_test.ts # version.ts
bartlomieju
reviewed
Apr 27, 2022
node/internal/child_process.ts
Outdated
Comment on lines
327
to
339
| function toDenoSignal(signal: number | string): Deno.Signal { | ||
| if (typeof signal === "number") { | ||
| for (const name of keys(os.signals)) { | ||
| if (os.signals[name] === signal) { | ||
| return name as Deno.Signal; | ||
| } | ||
| } | ||
| throw new ERR_UNKNOWN_SIGNAL(String(signal)); | ||
| } | ||
|
|
||
| const denoSignal = signal as Deno.Signal; | ||
| if (os.signals[denoSignal] != null) { | ||
| return denoSignal; |
There was a problem hiding this comment.
Seems like unrelated change
|
Can you add any test case? |
18 tasks
|
Closing in favor of #2457 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.