Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(fs/unstable): add rename #6379

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

jbronder
Copy link
Contributor

@jbronder jbronder commented Feb 4, 2025

This PR adds the rename API to @std/fs, which is intended to mirror Deno.rename function.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner February 4, 2025 00:17
@github-actions github-actions bot added the fs label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (1f032bb) to head (a73af8b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_rename.ts 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6379      +/-   ##
==========================================
- Coverage   96.24%   96.23%   -0.02%     
==========================================
  Files         555      556       +1     
  Lines       42047    42065      +18     
  Branches     6369     6371       +2     
==========================================
+ Hits        40470    40481      +11     
- Misses       1537     1544       +7     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jbronder !

@kt3k kt3k merged commit 3b75ee7 into denoland:main Feb 4, 2025
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants