Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Entity Embed option in Rich text editor #3292

Closed
kevwalsh opened this issue Oct 26, 2020 · 0 comments
Closed

Remove Entity Embed option in Rich text editor #3292

kevwalsh opened this issue Oct 26, 2020 · 0 comments
Labels
Content forms [CMS feature] crew-sitewide Epic Issue type Media [CMS feature] Editors can upload and share multimedia Needs refining Issue status Technical debt VAMC CMS managed product owned by Facilities team

Comments

@kevwalsh
Copy link
Contributor

kevwalsh commented Oct 26, 2020

Background

At some point entity embed was added to the rich text editor, with a File autocomplete widget. Original "entity embed" issue from Jira: https://va-gov.atlassian.net/browse/VAGOV-5784

It's not a great UX for editors.

  • the E button is ambiguous
  • the file autocomplete is pretty opaque.

It encourages a pattern that is discouraged in the design system.

Links_-_VA_gov_Design_System

Also, there are bugs associated with the front end build of these embedded entities, with file URLs that are not properly rewritten. department-of-veterans-affairs/va.gov-team#13455 ... files are only available from within the VA network.

User Story or Problem Statement

We need to decide if this should be improved or removed. It's also possible to remove it for now, then relaunch it at some point in an improved state.

"Improve" approach

1. Improve the entity browser experience
1. Front end work to make these files

"Remove" approach

  1. Audit to find any files that are linked this way
  2. Rewrite these links as content blocks where possible (?)
  3. Consider adding structured fields for files?

Affected users and stakeholders

  • All editors.
@kevwalsh kevwalsh added Epic Issue type Content forms [CMS feature] Media [CMS feature] Editors can upload and share multimedia Needs refining Issue status Technical debt VAMC CMS managed product owned by Facilities team vsa-facilities labels Oct 26, 2020
@kevwalsh kevwalsh changed the title Improve or remove Entity Embed option in Rich text editor Improve and/or remove Entity Embed option in Rich text editor Oct 26, 2020
@oksana-c oksana-c changed the title Improve and/or remove Entity Embed option in Rich text editor Remove Entity Embed option in Rich text editor Jan 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Content forms [CMS feature] crew-sitewide Epic Issue type Media [CMS feature] Editors can upload and share multimedia Needs refining Issue status Technical debt VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

2 participants