Adds handler to fix private registries timeout and socket errors (#11523

)
dependabot · Feb 7, 2025 · 2defbee · 2defbee
1 parent 0e52414
commit 2defbee
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/terraform/lib/dependabot/terraform/registry_client.rb b/terraform/lib/dependabot/terraform/registry_client.rb
@@ -195,6 +195,8 @@ def http_get(url)
           url: url.to_s,
           headers: headers_for(hostname)
         )
+      rescue Excon::Error::Socket, Excon::Error::Timeout
+        raise PrivateSourceBadResponse, hostname
       end
 
       sig { params(url: URI::Generic).returns(Excon::Response) }

diff --git a/terraform/spec/dependabot/terraform/registry_client_spec.rb b/terraform/spec/dependabot/terraform/registry_client_spec.rb
@@ -283,6 +283,16 @@
       end
     end
 
+    context "when the metadata endpoint is not reachable with Timeout error" do
+      it "raises an error" do
+        stub_request(:get, metadata).to_raise(Excon::Error::Timeout)
+
+        expect do
+          client.service_url_for("modules.v1")
+        end.to raise_error(Dependabot::PrivateSourceBadResponse)
+      end
+    end
+
     context "when the service url is not available" do
       it "raises an error" do
         stub_request(:get, metadata).and_return(body: { "modules.v1": "/v1/modules/" }.to_json)