Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use native JSON in Elixir #11295

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Use native JSON in Elixir #11295

merged 2 commits into from
Jan 22, 2025

Conversation

TylerWitt
Copy link
Contributor

@TylerWitt TylerWitt commented Jan 14, 2025

What are you trying to accomplish?

This removes the only dependency used for Elixir in processing the Hex ecosystem.

It should remove some dependency management from maintaining Hex, as it's all within Elixir's standard library now.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@TylerWitt TylerWitt requested a review from a team as a code owner January 14, 2025 09:59
@github-actions github-actions bot added the L: elixir:hex Elixir packages via hex label Jan 14, 2025
@TylerWitt TylerWitt marked this pull request as draft January 14, 2025 14:44
@abdulapopoola
Copy link
Member

Thanks @TylerWitt , looking forward to your contribution!

@TylerWitt TylerWitt mentioned this pull request Jan 15, 2025
5 tasks
@TylerWitt
Copy link
Contributor Author

Stalled on elixir-lang/elixir#14193

JSON now ships with Elixir 1.18, which means that the Elixir portion of the Hex processing can now remove Jason, and have no dependencies.

This simplifies some uncommon (to most) mix environment setup that adds some friction to onboarding.
@TylerWitt TylerWitt marked this pull request as ready for review January 20, 2025 13:50
@thavaahariharangit thavaahariharangit merged commit 83b4d5d into dependabot:main Jan 22, 2025
39 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
L: elixir:hex Elixir packages via hex
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants