do null check before attempting to install sdk #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-sdk-null-check
branch
2 times, most recently
from
5c01cf3 to
e6c1f86
Compare
ByAgenT
approved these changes
Jan 16, 2025
randhircs
force-pushed
the
dev/brettfo/nuget-sdk-null-check
branch
from
e6c1f86 to
59d3cf3
Compare
randhircs
force-pushed
the
dev/brettfo/nuget-sdk-null-check
branch
from
59d3cf3 to
6754717
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK installer wasn't actually verifying that the property
$globalJson.sdk.versionis present. This would have broken the install step a few lines down.