-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bump Hex Elixir to 1.15 #11319
Bump Hex Elixir to 1.15 #11319
Conversation
Bumps Elixir to 1.15.8 within Hex. There's a few notable changes due to the upgrade. 1. When Mix tries to process remote_convergers (Hex.RemoteConverger), Hex.Mix and other nested hex modules weren't loaded. 2. The term -> binary -> term message passing from run.exs to the other scripts now has Base.encode64/decode64 calls in order to make sure the binaries can be processed by IO.write 3. :hex and :ssh are added as extra_applications 4. The deps_warning mixfile needed a new kind of warning for the associated test to still pass. The old mixfile raises an error due to the missing parens on `deps` now.
786611a
to
05b611a
Compare
This closes #8622 |
I also have PRs on my fork for 1.16, 1.17, and 1.18 (separately). Is that the preference? Or is it better to just jump to 1.18? I figure it would be good to keep the blames correct and the separation helps in case there is any reversions needed. |
Thanks @TylerWitt , we're fine doing a sequential rollout for clarity. |
@@ -5,13 +5,15 @@ defmodule DependencyHelper do | |||
|> run() | |||
|> case do | |||
{output, 0} -> | |||
output = Base.decode64!(output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerWitt Thanks for all your work on updating Elixir/OTP for dependabot 🙏
Reporting back on an issue having after these changes...
Apparently getting "\n"
out of the encoded output of parse_deps.exs
and raising here when trying to decode back?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you raise an issue and post the full stacktrace? Thanks!
It's probably that errors need to also be encoded now.
What are you trying to accomplish?
Bumps Elixir to 1.15.8 within Hex.
There's a few notable changes due to the upgrade.
deps
now.Checklist