Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump Hex Elixir to 1.15 #11319

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

TylerWitt
Copy link
Contributor

@TylerWitt TylerWitt commented Jan 16, 2025

What are you trying to accomplish?

Bumps Elixir to 1.15.8 within Hex.

There's a few notable changes due to the upgrade.

  1. When Mix tries to process remote_convergers (Hex.RemoteConverger), Hex.Mix and other nested hex modules weren't loaded.
  2. The term -> binary -> term message passing from run.exs to the other scripts now has Base.encode64/decode64 calls in order to make sure the binaries can be processed by IO.write
  3. :hex and :ssh are added as an extra_applications
  4. The deps_warning mixfile needed a new kind of warning for the associated test to still pass. The old mixfile raises an error due to the missing parens on deps now.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: elixir:hex Elixir packages via hex label Jan 16, 2025
Bumps Elixir to 1.15.8 within Hex.

There's a few notable changes due to the upgrade.
1. When Mix tries to process remote_convergers (Hex.RemoteConverger), Hex.Mix and other nested hex modules weren't loaded.
2. The term -> binary -> term message passing from run.exs to the other scripts now has Base.encode64/decode64 calls in order to make sure the binaries can be processed by IO.write
3. :hex and :ssh are added as extra_applications
4. The deps_warning mixfile needed a new kind of warning for the associated test to still pass. The old mixfile raises an error due to the missing parens on `deps` now.
@TylerWitt TylerWitt force-pushed the Bump-Elixir-to-1.15 branch from 786611a to 05b611a Compare January 16, 2025 14:44
@TylerWitt TylerWitt marked this pull request as ready for review January 16, 2025 14:44
@TylerWitt TylerWitt requested a review from a team as a code owner January 16, 2025 14:44
@TylerWitt
Copy link
Contributor Author

This closes #8622

@TylerWitt
Copy link
Contributor Author

I also have PRs on my fork for 1.16, 1.17, and 1.18 (separately).

Is that the preference? Or is it better to just jump to 1.18?

I figure it would be good to keep the blames correct and the separation helps in case there is any reversions needed.

@abdulapopoola
Copy link
Member

Thanks @TylerWitt , we're fine doing a sequential rollout for clarity.

@thavaahariharangit thavaahariharangit merged commit 028a428 into dependabot:main Jan 16, 2025
39 checks passed
@@ -5,13 +5,15 @@ defmodule DependencyHelper do
|> run()
|> case do
{output, 0} ->
output = Base.decode64!(output)
Copy link

@grzuy grzuy Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerWitt Thanks for all your work on updating Elixir/OTP for dependabot 🙏

Reporting back on an issue having after these changes...

image

Apparently getting "\n" out of the encoded output of parse_deps.exs and raising here when trying to decode back?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you raise an issue and post the full stacktrace? Thanks!

It's probably that errors need to also be encoded now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
L: elixir:hex Elixir packages via hex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants