Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds error handler for Ruby version not found class error #11362

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 21, 2025

What are you trying to accomplish?

Adds error handler for Ruby version not found class so that they don't end up being in Sentry.

Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RubyVersionNotFound: Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RubyVersionNotFound
  bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:65:in `ruby_version'
  bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:33:in `rewrite'
  bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:262:in `block in lock_ruby_version'
  bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:260:in `each'
  bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:260:in `lock_ruby_version'

...
(50 additional frame(s) were not displayed)

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 21, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fileupdater-rubyrequirementdetter branch from c85cbf1 to 078676d Compare January 22, 2025 02:13
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Jan 22, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fileupdater-rubyrequirementdetter branch 3 times, most recently from bd0560c to 0a5aabc Compare January 22, 2025 14:15
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 22, 2025 14:36
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 22, 2025 14:36
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fileupdater-rubyrequirementdetter branch from 0a5aabc to fe6660d Compare January 22, 2025 14:37
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fileupdater-rubyrequirementdetter branch 2 times, most recently from 80acb21 to 677745d Compare January 22, 2025 15:48
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/fileupdater-rubyrequirementdetter branch from 7ff42f9 to ef43b4c Compare January 22, 2025 16:28
@sachin-sandhu sachin-sandhu merged commit 6b32887 into main Jan 22, 2025
82 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/fileupdater-rubyrequirementdetter branch January 22, 2025 17:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants