improve sdk version robustness and tests to allow for empty object #11378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-install-sdk
branch
from
4769b1f to
c6b680c
Compare
sebasgomez238
approved these changes
Jan 22, 2025
randhircs
force-pushed
the
dev/brettfo/nuget-install-sdk
branch
from
f5ebc99 to
b95dfaf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK installer script couldn't handle a
global.jsonfile with an empty object{}. This PR fixes that and updates the tests to be able to directly verify the SDK versions that would be installed.This also improves handling when the starting directories contain wildcards (e.g.,
/**) and when directories don't exist.