Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added sorbettype check as strict #11379

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

randhircs
Copy link
Member

@randhircs randhircs commented Jan 22, 2025

What are you trying to accomplish?

Added sorbettype check as strict for python/lib/dependabot/python/file_parser/pipfile_files_parser.rb

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

It should pass all the test cases and post deployment it should not break.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@randhircs randhircs requested a review from a team as a code owner January 22, 2025 18:53
@randhircs randhircs marked this pull request as draft January 22, 2025 18:54
@randhircs randhircs self-assigned this Jan 22, 2025
@randhircs randhircs marked this pull request as ready for review January 22, 2025 21:01
Copy link
Contributor

@thavaahariharangit thavaahariharangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the developers haven't considered typing, while implementation. Only the stuff we can change that we are so sure of it rest we need to leave it T.untyped.

Other wise need to update the implementation.

On this note I am approving this PR.

@randhircs randhircs force-pushed the randhircs/sorbet_typecheck_as_strict_python_module branch from dc059e5 to 029a011 Compare January 23, 2025 13:58
@randhircs randhircs merged commit e9bcde4 into main Jan 23, 2025
60 checks passed
@randhircs randhircs deleted the randhircs/sorbet_typecheck_as_strict_python_module branch January 23, 2025 14:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants